[PATCH 1/1] ASoC: cs42l51: add soft dependency declaration

[Olivier MOYSAN]

Hello Mark,





On 10/2/20 5:41 PM, Mark Brown wrote:

On Fri, Oct 02, 2020 at 05:29:04PM +0200, Olivier Moysan wrote:


When configured as module, CS42L51 codec driver uses two modules
snd-soc-cs42l51 and snd-soc-cs42l51-i2c.
Add soft dependency on snd-soc-cs42l51-i2c in snd-soc-cs42l51,
to allow smart module dependency solving.



Doesn't the userspace tooling usually manage to figure this out from
symbol usage?



cs42l51.c does not use symbols from cs42l51-i2c.c, so cs42l51-i2c does not appear
as a software dependency of cs42l51, for tools such as depmod.
(cs42l51-i2c.c uses symbols from cs42l51.c,
so there is a dependency in this way, but this does not help here)


When enabling a sound card based on cs42l51, all required modules are loaded automatically,
excepted snd-soc-cs42l51-i2c module. This one has to be inserted explicitely.

With the use of softdep, cs42l51-i2c appears as a dependency of cs42l51 for depmod,
which allows the probe of snd-soc-cs42l51-i2c.


If you think there is a better way to manage this dependency please let me know.

Regards
Olivier