[PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe
Geoff Levand
geoff at infradead.org
Fri Nov 27 20:39:51 CET 2020
On 11/27/20 7:22 AM, Leonard Goehrs wrote:
> The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed
> in ps3_system_bus_init() before registering the driver. So if the probe
> function is actually used, this feature is already known to be available.
>
> The check for the match id is also superfluous; the condition is always
> true because the bus' match function (ps3_system_bus_match()) only
> considers this driver for devices having:
> dev->match_id == snd_ps3_bus_driver_info.match_id.
>
> Suggested-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Signed-off-by: Leonard Goehrs <l.goehrs at pengutronix.de>
Seems OK with v5.9 on PS3.
Tested by: Geoff Levand <geoff at infradead.org>
More information about the Alsa-devel
mailing list