[PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void
Geert Uytterhoeven
geert at linux-m68k.org
Fri Nov 27 09:40:04 CET 2020
Hi Uwe,
On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
> The driver core ignores the return value of struct device_driver::remove
> because there is only little that can be done. For the shutdown callback
> it's ps3_system_bus_shutdown() which ignores the return value.
>
> To simplify the quest to make struct device_driver::remove return void,
> let struct ps3_system_bus_driver::remove return void, too. All users
> already unconditionally return 0, this commit makes it obvious that
> returning an error code is a bad idea and ensures future users behave
> accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert at linux-m68k.org>
Note that the same can be done for ps3_vuart_port_driver.remove().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the Alsa-devel
mailing list