[PATCH] ASoC: fsl_xcvr: fix potential resource leak

Viorel Suman (OSS) viorel.suman at oss.nxp.com
Tue Nov 24 15:19:57 CET 2020


From: Viorel Suman <viorel.suman at nxp.com>

"fw" variable must be relased before return.

Signed-off-by: Viorel Suman <viorel.suman at nxp.com>
---
 sound/soc/fsl/fsl_xcvr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c
index 2a28810d0e29..3d58c88ea603 100644
--- a/sound/soc/fsl/fsl_xcvr.c
+++ b/sound/soc/fsl/fsl_xcvr.c
@@ -706,6 +706,7 @@ static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr)
 	/* RAM is 20KiB = 16KiB code + 4KiB data => max 10 pages 2KiB each */
 	if (rem > 16384) {
 		dev_err(dev, "FW size %d is bigger than 16KiB.\n", rem);
+		release_firmware(fw);
 		return -ENOMEM;
 	}
 
-- 
2.26.2



More information about the Alsa-devel mailing list