[PATCH 13/14] ASoC: SOF: Intel: allow for coexistence between SOF and catpt drivers
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Thu Nov 19 18:52:22 CET 2020
On 11/19/20 8:06 AM, Mark Brown wrote:
> On Thu, Nov 12, 2020 at 04:38:24PM -0600, Pierre-Louis Bossart wrote:
>> Now that we have all the support needed for coexistence between ACPI
>> drivers for Broadwell, remove mutual exclusion in the Kconfig
>> file. The selection is done by playing with the snd_intel_dspcfg
>> module 'dsp_driver' parameter.
>
> This breaks x86 allmodconfig builds for me:
>
> /mnt/kernel/sound/soc/intel/atom/sst/sst_acpi.c: In function 'sst_acpi_probe':
> /mnt/kernel/sound/soc/intel/atom/sst/sst_acpi.c:251:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
> /mnt/kernel/sound/soc/intel/catpt/device.c: In function 'catpt_acpi_probe':
> /mnt/kernel/sound/soc/intel/catpt/device.c:251:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
> /mnt/kernel/sound/soc/sof/sof-acpi-dev.c: In function 'sof_acpi_probe':
> /mnt/kernel/sound/soc/sof/sof-acpi-dev.c:134:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
>
Humm, I just tried and it works fine for me on top of your for-5.11
branch. That error across the board seems weird, there's even a
fall-back with a static inline if the Kconfig is not selected.
Could it be that Patch3 was not applied somehow? That's where the
prototype was added.
More information about the Alsa-devel
mailing list