[PATCH] ALSA: ctl: fix error path at adding user-defined element set

Takashi Iwai tiwai at suse.de
Fri Nov 13 11:34:39 CET 2020


On Fri, 13 Nov 2020 10:20:43 +0100,
Takashi Sakamoto wrote:
> 
> When processing request to add/replace user-defined element set, check
> of given element identifier and decision of numeric identifier is done
> in "__snd_ctl_add_replace()" helper function. When the result of check
> is wrong, the helper function returns error code. The error code shall
> be returned to userspace application.
> 
> Current implementation includes bug to return zero to userspace application
> regardless of the result. This commit fixes the bug.
> 
> Cc: <stable at vger.kernel.org>
> Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element")
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Thanks, applied now.


Takashi


More information about the Alsa-devel mailing list