[PATCH v2 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Nov 3 16:51:51 CET 2020



>>> +static bool wsa_macro_adie_lb(struct snd_soc_component *component,
>>> +                  int interp_idx)
>>> +{
>>> +    u16 int_mux_cfg0 = 0, int_mux_cfg1 = 0;
>>
>> these inits are ignored
>>
>>> +    u8 int_mux_cfg0_val = 0, int_mux_cfg1_val = 0;
>>
>> these as well
>>
>>> +    u8 int_n_inp0 = 0, int_n_inp1 = 0, int_n_inp2 = 0;
>>
>> and these are also ignored.
>>
> Yes, these are ignored, I should have removed the unnecessary 
> initialization!
> It would have been nice if sparse could catch such errors!
> 
> are you using tool to catch these?

make W=1 and cppcheck.

"
Run cppcheck on this sort of code:

cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive
--enable=all --suppress=variableScope sound/soc/codecs/lpass-wsa-macro.c
"


More information about the Alsa-devel mailing list