[PATCH] ASoC: rt1015: add delay to fix pop noise from speaker

Mark Brown broonie at kernel.org
Mon Nov 2 16:41:07 CET 2020


On Mon, Nov 02, 2020 at 08:45:33AM -0600, Pierre-Louis Bossart wrote:

> > +static void rt1015_parse_dt(struct rt1015_priv *rt1015, struct device *dev)
> > +{
> > +	device_property_read_u32(dev, "realtek,power-up-delay",
> > +		&rt1015->pdata.power_up_delay);
> > +}

> Don't you need a DT binding description? And use delay-ms maybe?

Yes, any new bindings need to be documented and things should have their
units as a suffix.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20201102/5a4e9aec/attachment.sig>


More information about the Alsa-devel mailing list