[PATCH] ASoC: ti: davinci-mcasp: remove always zero of davinci_mcasp_get_dt_params

[Peter Ujfalusi]

Hi,

On 02/11/2020 12.34, Zhang Qilong wrote:
> davinci_mcasp_get_dt_params alway return zero, and its return value
> could be ignored by the caller. So make it 'void' type to avoid the
> check its return value.

Thanks for updating the patch!

Acked-by: Peter Ujfalusi <peter.ujfalusi at ti.com>

> 
> Fixes: 764958f2b5239 ("ASoC: ti: davinci-mcasp: Support for auxclk-fs-ratio")
> Signed-off-by: Zhang Qilong <zhangqilong3 at huawei.com>
> ---
>  sound/soc/ti/davinci-mcasp.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 4b46dd827f3f..63c492862383 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2112,20 +2112,18 @@ static inline int davinci_mcasp_init_gpiochip(struct davinci_mcasp *mcasp)
>  }
>  #endif /* CONFIG_GPIOLIB */
>  
> -static int davinci_mcasp_get_dt_params(struct davinci_mcasp *mcasp)
> +static void davinci_mcasp_get_dt_params(struct davinci_mcasp *mcasp)
>  {
>  	struct device_node *np = mcasp->dev->of_node;
>  	int ret;
>  	u32 val;
>  
>  	if (!np)
> -		return 0;
> +		return;
>  
>  	ret = of_property_read_u32(np, "auxclk-fs-ratio", &val);
>  	if (ret >= 0)
>  		mcasp->auxclk_fs_ratio = val;
> -
> -	return 0;
>  }
>  
>  static int davinci_mcasp_probe(struct platform_device *pdev)
> @@ -2361,9 +2359,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err;
>  
> -	ret = davinci_mcasp_get_dt_params(mcasp);
> -	if (ret)
> -		return -EINVAL;
> +	davinci_mcasp_get_dt_params(mcasp);
>  
>  	ret = devm_snd_soc_register_component(&pdev->dev,
>  					&davinci_mcasp_component,
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki