[PATCH] firewire: Remove function callback casts

Oscar Carter oscar.carter at gmx.com
Tue May 19 18:59:11 CEST 2020


On Sun, May 17, 2020 at 07:43:21PM +0300, Lev R. Oshvang . wrote:
>
> Hi Oscar,
> I would recommend to explicitly set NULL to _cb and use if elif to
> exclude the case where botm _cb paraneters are passed as NULLs :
> > +
>   ctx->callback.mc =NULL:
>   ctx->callback.sc = NULL;
> > +       if (cb_sc)
> > +               ctx->callback.sc = cb_sc;
>
> > +       elif (cb_ms)
> > +               ctx->callback.mc = cb_mc;
> > +         else
>                     return -EINVAL;

Ok, I will do the changes you suggested and I will resend a new version.

> Hope you get the point.
> Lev

Thanks,
Oscar Carter


More information about the Alsa-devel mailing list