[PATCH v3 00/14] Add Renoir ACP driver

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon May 18 19:31:39 CEST 2020



On 5/18/20 12:16 PM, Vijendar Mukunda wrote:
> This adds an ASoC driver for the ACP (Audio CoProcessor)
> block on AMD Renoir APUs.

All my feedback was taken into account and I didn't see any new issues so:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

I wouldn't hurt to have additional reviewers though.

> V3:
> - Changed PCI driver PM runtime sequence
> - Removed redundant code in Renoir machine driver
> 
> V2:
> - Removed empty declaration of dai_ops
> - Removed SNDRV_PCM_INFO_BATCH flag
> - Defined Macros for delay and counter and corrected dma stop sequence.
> - Changed PCI driver pm runtime sequence
> - Removed redundant code
> 
> 
> Vijendar Mukunda (14):
>    ASoC: amd: add Renoir ACP3x IP register header
>    ASoC: amd: add Renoir ACP PCI driver
>    ASoC: amd: add acp init/de-init functions
>    ASoC: amd: create acp3x pdm platform device
>    ASoC: amd: add ACP3x PDM platform driver
>    ASoC: amd: irq handler changes for ACP3x PDM dma driver
>    ASoC: amd: add acp3x pdm driver dma ops
>    ASoC: amd: add ACP PDM DMA driver dai ops
>    ASoC: amd: add Renoir ACP PCI driver PM ops
>    ASoC: amd: add ACP PDM DMA driver pm ops
>    ASoC: amd: enable Renoir acp3x drivers build
>    ASoC: amd: create platform devices for Renoir
>    ASoC: amd: RN machine driver using dmic
>    ASoC: amd: enable build for RN machine driver
> 
>   sound/soc/amd/Kconfig                      |  13 +
>   sound/soc/amd/Makefile                     |   1 +
>   sound/soc/amd/renoir/Makefile              |   7 +
>   sound/soc/amd/renoir/acp3x-pdm-dma.c       | 530 +++++++++++++++++++++
>   sound/soc/amd/renoir/acp3x-rn.c            |  77 +++
>   sound/soc/amd/renoir/rn-pci-acp3x.c        | 344 +++++++++++++
>   sound/soc/amd/renoir/rn_acp3x.h            |  88 ++++
>   sound/soc/amd/renoir/rn_chip_offset_byte.h | 349 ++++++++++++++
>   8 files changed, 1409 insertions(+)
>   create mode 100644 sound/soc/amd/renoir/Makefile
>   create mode 100644 sound/soc/amd/renoir/acp3x-pdm-dma.c
>   create mode 100644 sound/soc/amd/renoir/acp3x-rn.c
>   create mode 100644 sound/soc/amd/renoir/rn-pci-acp3x.c
>   create mode 100644 sound/soc/amd/renoir/rn_acp3x.h
>   create mode 100644 sound/soc/amd/renoir/rn_chip_offset_byte.h
> 


More information about the Alsa-devel mailing list