[PATCH v2 13/14] ASoC: amd: RN machine driver using dmic

[Mukunda, Vijendar]

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Sent: Tuesday, May 12, 2020 4:07 AM
> To: Alex Deucher <alexdeucher at gmail.com>; alsa-devel at alsa-project.org;
> broonie at kernel.org; Mukunda, Vijendar <Vijendar.Mukunda at amd.com>;
> tiwai at suse.de
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: Re: [PATCH v2 13/14] ASoC: amd: RN machine driver using dmic
> 
> 
> 
> 
> > +static int acp_pdm_hw_params(struct snd_pcm_substream *substream,
> > +			     struct snd_pcm_hw_params *hw_params)
> > +{
> > +	return 0;
> > +}
> 
> is this needed?

Will remove it.
> 
> > +
> > +static struct snd_soc_ops acp_pdm_ops = {
> > +	.hw_params = acp_pdm_hw_params,
> > +};
> > +
> > +static int acp_init(struct snd_soc_pcm_runtime *rtd)
> > +{
> > +	return 0;
> > +}
> 
> is this needed?

Will remove it.

> 
> 
> > +static struct platform_driver acp_mach_driver = {
> > +	.driver = {
> > +		.name = "acp_pdm_mach",
> > +		.pm = &snd_soc_pm_ops,
> > +	},
> > +	.probe = acp_probe,
> > +};
> > +
> > +static int __init acp_audio_init(void)
> > +{
> > +	platform_driver_register(&acp_mach_driver);
> > +	return 0;
> > +}
> > +
> > +static void __exit acp_audio_exit(void)
> > +{
> > +	platform_driver_unregister(&acp_mach_driver);
> > +}
> > +
> > +module_init(acp_audio_init);
> > +module_exit(acp_audio_exit);
> 
> use module_platform_driver() - was already feedback on v1...

Sorry, I have over looked it. Will fix it.