[PATCH] ASoC: topology: log all headers being parsed

Keyon Jie yang.jie at linux.intel.com
Sat May 9 10:22:48 CEST 2020


The check (tplg->pass == le32_to_cpu(hdr->type)) makes no sense as it is
comparing two different enums, remove the check and log all headers that
being parsed.

Signed-off-by: Keyon Jie <yang.jie at linux.intel.com>
---
 sound/soc/soc-topology.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 49875978a1ce..58cf5a12af3f 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -2685,11 +2685,10 @@ static int soc_valid_header(struct soc_tplg *tplg,
 		return -EINVAL;
 	}
 
-	if (tplg->pass == le32_to_cpu(hdr->type))
-		dev_dbg(tplg->dev,
-			"ASoC: Got 0x%x bytes of type %d version %d vendor %d at pass %d\n",
-			hdr->payload_size, hdr->type, hdr->version,
-			hdr->vendor_type, tplg->pass);
+	dev_dbg(tplg->dev,
+		"ASoC: Got 0x%x bytes of type %d version %d vendor %d at pass %d\n",
+		hdr->payload_size, hdr->type, hdr->version,
+		hdr->vendor_type, tplg->pass);
 
 	return 1;
 }
-- 
2.20.1



More information about the Alsa-devel mailing list