[PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Wed Mar 25 15:42:35 CET 2020
On 3/25/20 8:28 AM, Cezary Rojewski wrote:
> On 2020-03-19 23:43, Curtis Malainey wrote:
>> On Thu, Mar 19, 2020 at 3:15 PM Pierre-Louis Bossart
>> <pierre-louis.bossart at linux.intel.com> wrote:
>>> On 3/19/20 3:49 PM, Cezary Rojewski wrote:
>>>> As of commit:
>>>> ASoC: soc-core: care .ignore_suspend for Component suspend
>>>>
>>>> function soc-core::snd_soc_suspend no longer ignores 'ignore_suspend'
>>>> flag for dai links. While BE dai link for System Pin is
>>>> supposed to follow standard suspend-resume flow, appended
>>>> 'ignore_suspend' flag disturbs that flow and causes audio to break
>>>> right after resume. Remove the flag to address this.
>>>>
>>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>>>> Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>>>> Cc: Dominik Brodowski <linux at dominikbrodowski.net>
>>>> Cc: Mark Brown <broonie at kernel.org>
>>>> Signed-off-by: Cezary Rojewski <cezary.rojewski at intel.com>
>>>
>>> we should ask Ben and Curtis @ Google if the changes related to suspend
>>> interfere with the wake-on-voice support?
>>
>> I have a samus with me so I can test it but my backlog is definitely
>> growing due to WFH slowness. I will see if I can take a look tomorrow.
>>
>
> Any update?
>
> Maybe let's leave bdw-rt5650/ bdw-rt5677 behind so people have more time
> to test and merge just the broadwell & haswell part. Hmm?
Can you give us a bit more time (couple of days tops)? we also see a
problem with SOF when playing after suspend-resume, and I just thought
this might be related to the same issue.
More information about the Alsa-devel
mailing list