[PATCH 6/6] ASoC: soc-pcm: Merge CPU/Codec MSB at soc_pcm_apply_msb()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Mar 18 01:07:35 CET 2020


Hi Lars-Peter

Thank you for your review

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > 
> > soc_pcm_apply_msb() is setting msb for both CPU/Codec,
> > but we can merge these into one.
> > This patch do it.
> 
> This patch changes the behavior. Before it was
> 
> min(max(ALL_CODEC_DAIS), max(ALL_CPU_DAIS))
> 
> Now it is just max(ALL_DAIS).

Grr, thank you for pointing it !!
Mark, can you please ignore this patch ?

> We really do need to differentiate between the DAIs on the transmit
> side and the DAIs on the receive side of a stream to compute this
> correctly.

It still have for_each_xxx for CPU / Codec same as before.
New system (= bridge ?) need to have it, but different naming.

Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list