[PATCH 06/14] ASoC: SOF: add a power status IPC

[Mark Brown]

On Thu, Mar 12, 2020 at 03:44:21PM +0100, Guennadi Liakhovetski wrote:

>  #endif
> +	atomic_set(&sdev->reset_count, 0);
>  	dev_set_drvdata(dev, sdev);

Do we really need to use atomics for this?  They are hard to use
correctly.

>  #include "ops.h"
> @@ -617,6 +618,9 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev)
>  	/* fw boot is complete. Update the active cores mask */
>  	sdev->enabled_cores_mask = init_core_mask;
>  
> +	/* increment reset count */
> +	atomic_add(1, &sdev->reset_count);
> +

We at no point seem to read from this reset counter?  I can't figure out
from this commit what it's doing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200313/50362932/attachment.sig>