[PATCH] ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example
Rob Herring
robh at kernel.org
Wed Mar 11 21:58:41 CET 2020
Extra dtc warnings (roughly what W=1 enables) are now enabled by default
when building the binding examples. These were fixed treewide in
5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
warnings:
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
Warning (unit_address_vs_reg): /example-0/cros-ec at 0: node has a unit name, but no reg property
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
Warning (unit_address_vs_reg): /example-0/cros-ec at 0/ec-codec: node has a reg or ranges property, but no unit name
Fixing the above, then results in:
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
Warning (reg_format): /example-0/cros-ec at 0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
Warning (unit_address_vs_reg): /example-0/cros-ec at 0/ec-codec: node has a reg or ranges property, but no unit name
Fixes: eadd54c75f1e ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
Cc: Cheng-Yi Chiang <cychiang at chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo at collabora.com>
Cc: Guenter Roeck <groeck at chromium.org>
Cc: Liam Girdwood <lgirdwood at gmail.com>
Cc: Mark Brown <broonie at kernel.org>
Cc: Benson Leung <bleung at chromium.org>
Cc: alsa-devel at alsa-project.org
Signed-off-by: Rob Herring <robh at kernel.org>
---
.../bindings/sound/google,cros-ec-codec.yaml | 27 +++++++++++--------
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
index 94a85d0cbf43..c84e656afb0a 100644
--- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
@@ -44,19 +44,24 @@ additionalProperties: false
examples:
- |
- reserved_mem: reserved_mem {
+ reserved_mem: reserved-mem at 52800000 {
compatible = "shared-dma-pool";
- reg = <0 0x52800000 0 0x100000>;
+ reg = <0x52800000 0x100000>;
no-map;
};
- cros-ec at 0 {
- compatible = "google,cros-ec-spi";
- #address-cells = <2>;
- #size-cells = <1>;
- cros_ec_codec: ec-codec {
- compatible = "google,cros-ec-codec";
- #sound-dai-cells = <1>;
- reg = <0x0 0x10500000 0x80000>;
- memory-region = <&reserved_mem>;
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cros-ec at 0 {
+ compatible = "google,cros-ec-spi";
+ #address-cells = <2>;
+ #size-cells = <1>;
+ reg = <0>;
+ cros_ec_codec: ec-codec at 10500000 {
+ compatible = "google,cros-ec-codec";
+ #sound-dai-cells = <1>;
+ reg = <0x0 0x10500000 0x80000>;
+ memory-region = <&reserved_mem>;
+ };
};
};
--
2.20.1
More information about the Alsa-devel
mailing list