[PATCH 2/3] ASoC: add function parameters to enable forced path pruning

Guennadi Liakhovetski guennadi.liakhovetski at linux.intel.com
Wed Mar 11 14:26:58 CET 2020


On Wed, Mar 11, 2020 at 12:41:02PM +0000, Mark Brown wrote:
> On Wed, Mar 11, 2020 at 01:36:17PM +0100, Guennadi Liakhovetski wrote:
> > On Wed, Mar 11, 2020 at 12:25:31PM +0000, Mark Brown wrote:
> 
> > > It's still not clear to me what the issue is here.  If something is
> > > making a modification to the graph which needs a recheck or update I'd
> > > expect that these things happen along with that modification.  I don't
> > > understand what you're saying about not being able to reproduce
> > > scenarios or adding things "on top".
> 
> > VirtIO support. That function currently exists in the kernel, but I don't 
> > have a test-case to verify its work, to see it called and actually perform 
> > the pruning. So I don't know how it is supposed to work. And because of 
> > that I cannot fix my VirtIO use case to use that function properly, without 
> > forcing it with an additional parameter.
> 
> I think you need to include this with your VirtIO series.

That was also my original intention, personally I also would find it difficult 
to review this kind of work without context.

So, would you prefer me to drop this series completely and re-send it with the 
whole series or should I just drop #2 and resend #1 and #3?

Thanks
Guennadi


More information about the Alsa-devel mailing list