[PATCH 0/9] ASoC: soc-pcm cleanup step6

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Mar 9 18:15:52 CET 2020


Thanks Morimoto-san,

>> We are using plural form for for_each_xxx() macro.
>> But, for_each_rtd_codec/cpu_dai() are out of this rule.
>> 1) - 7) are for it.
>> 8) - 9) add new for_each_card_xxx() macros.
>>
>> Kuninori Morimoto (9):
>>     1) ASoC: soc.h: add for_each_rtd_codecs/cpus_dai() macro
>>     2) ASoC: Intel: use for_each_rtd_codecs/cpus_dai() macro
>>     3) ASoC: mediatek: use for_each_rtd_codecs/cpus_dai() macro
>>     4) ASoC: meson: use for_each_rtd_codecs/cpus_dai() macro
>>     5) ASoC: qcom: use for_each_rtd_codecs/cpus_dai() macro
>>     6) ASoC: soc: use for_each_rtd_codecs/cpus_dai() macro
>>     7) ASoC: soc.h: remove non plural form for_each_xxx macro
>>     8) ASoC: soc-dapm: add for_each_card_dapms() macro
>>     9) ASoC: soc-dapm: add for_each_card_widgets() macro
> 
> LGTM Morimoto-san. I feel like the last 2 patches might be a bit of an
> overkill but then they might make sense to keep the code consistent with
> the use of the for_each*() macros everywhere.
> 
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>

LGTM as well.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>



More information about the Alsa-devel mailing list