[PATCH] ASoC: rt1015: add missing header inclusion

Mark Brown broonie at kernel.org
Wed Jun 24 17:41:09 CEST 2020


On Wed, Jun 24, 2020 at 01:36:27PM +0800, Tzung-Bi Shih wrote:
> To fix compile error:
> 
> error: implicit declaration of function 'ACPI_PTR'
> [-Werror,-Wimplicit-function-declaration]
>                 .acpi_match_table = ACPI_PTR(rt1015_acpi_match),
> 		                    ^
> 
> Adds the missing header inclusion and sorts in alphabetical.

This breaks the build for an x86 allmodconfig:

In file included from /mnt/kernel/sound/soc/codecs/rt1015.c:27:
/mnt/kernel/include/sound/soc-dapm.h:435:39: warning: 'struct snd_soc_pcm_runtime' declared inside parameter list will not be visible outside of this definition or declaration
 void snd_soc_dapm_stream_event(struct snd_soc_pcm_runtime *rtd, int stream,
                                       ^~~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:437:38: warning: 'struct snd_soc_pcm_runtime' declared inside parameter list will not be visible outside of this definition or declaration
 void snd_soc_dapm_stream_stop(struct snd_soc_pcm_runtime *rtd, int stream);
                                      ^~~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:445:50: warning: 'struct soc_enum' declared inside parameter list will not be visible outside of this definition or declaration
   struct snd_kcontrol *kcontrol, int mux, struct soc_enum *e,
                                                  ^~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:494:7: warning: 'enum snd_soc_bias_level' declared inside parameter list will not be visible outside of this definition or declaration
  enum snd_soc_bias_level level);
       ^~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:668:26: error: field 'bias_level' has incomplete type
  enum snd_soc_bias_level bias_level;
                          ^~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:678:26: error: field 'target_bias_level' has incomplete type
  enum snd_soc_bias_level target_bias_level;
                          ^~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:725:61: error: parameter 2 ('level') has incomplete type
  struct snd_soc_dapm_context *dapm, enum snd_soc_bias_level level)
                                     ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/mnt/kernel/include/sound/soc-dapm.h:724:20: error: function declaration isn't a prototype [-Werror=strict-prototypes]
 static inline void snd_soc_dapm_init_bias_level(
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:736:39: error: return type is an incomplete type
 static inline enum snd_soc_bias_level snd_soc_dapm_get_bias_level(
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h: In function 'snd_soc_dapm_get_bias_level':
/mnt/kernel/include/sound/soc-dapm.h:739:9: warning: 'return' with a value, in function returning void
  return dapm->bias_level;
         ^~~~
/mnt/kernel/include/sound/soc-dapm.h:736:39: note: declared here
 static inline enum snd_soc_bias_level snd_soc_dapm_get_bias_level(
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /mnt/kernel/include/sound/soc.h:1424,
                 from /mnt/kernel/sound/soc/codecs/rt1015.c:28:
/mnt/kernel/include/sound/soc-component.h: In function 'snd_soc_component_get_bias_level':
/mnt/kernel/include/sound/soc-component.h:281:9: error: void value not ignored as it ought to be
  return snd_soc_dapm_get_bias_level(
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   snd_soc_component_get_dapm(component));
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc-component.h: In function 'snd_soc_component_force_bias_level':
/mnt/kernel/include/sound/soc-component.h:299:3: error: type of formal parameter 2 is incomplete
   level);
   ^~~~~
cc1: some warnings being treated as errors
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200624/889918e8/attachment.sig>


More information about the Alsa-devel mailing list