[PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

Shengjiu Wang shengjiu.wang at gmail.com
Tue Jun 23 10:32:02 CEST 2020


On Tue, Jun 23, 2020 at 3:38 PM Markus Elfring <Markus.Elfring at web.de> wrote:
>
> > In-Reply-To: <cover.1592888591.git.shengjiu.wang at nxp.com>
>
> I guess that it should be sufficient to specify such a field once
> for the header information.

seems it's caused by my "git format-patch" command, I will update
it, hope it is better next time.

>
>
> > Because clk_prepare_enable and clk_disable_unprepare should
> > check input clock parameter is NULL or not internally,
>
> I find this change description unclear.

    clk_prepare_enable and clk_disable_unprepare check the input
    clock parameter in the beginning of the function, if the parameter
    is NULL, clk_prepare_enable and clk_disable_unprepare will
    return immediately.

    So Don't need to check input clock parameters before calling clk
    API.

Do you think this commit message is better?

best regards
wang shengjiu


More information about the Alsa-devel mailing list