[PATCH] ASoC: codecs: Added MAX98373 Soundwire Driver

[Ryan Lee]

>-----Original Message-----
>From: Mark Brown <broonie at kernel.org>
>Sent: Thursday, June 18, 2020 8:11 AM
>To: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>Cc: Guennadi Liakhovetski <guennadi.liakhovetski at linux.intel.com>; alsa-
>devel at alsa-project.org; Ryan Lee <RyanS.Lee at maximintegrated.com>;
>tiwai at suse.de; gregkh at linuxfoundation.org; vkoul at kernel.org; Naveen
>Manohar <naveen.m at intel.com>; Bard liao <yung-
>chuan.liao at linux.intel.com>; Rander Wang <rander.wang at linux.intel.com>
>Subject: Re: [PATCH] ASoC: codecs: Added MAX98373 Soundwire Driver
>
>On Thu, Jun 18, 2020 at 07:42:25AM -0500, Pierre-Louis Bossart wrote:
>
>> > The DT bindings need updating to add SoundWire support.
>
>> Interesting. The properties are the same in I2C and SoundWire mode, so
>> would we need a completely different file that just specifies the
>> SoundWire DeviceID, e.g.
>
>> properties:
>>   compatible:
>>     const: sdw10217201000
>
>> What's the process for such dual-mode devices?
>
>I'd hope it could be added to the existing bindings document like for other
>dual bus devices.
>
>> > > +	regmap_write(max98373->regmap,
>> > > +		     MAX98373_R203D_AMP_DIG_VOL_CTRL,
>> > > +		     0x00);
>> > > +	regmap_write(max98373->regmap,
>> > > +		     MAX98373_R203E_AMP_PATH_GAIN,
>> > > +		     0x00);
>
>> > I'd expect these to be chip defaults, especially the volumes.
>
>> The same sequence is already used in the I2C probe. if this needs to
>> change, it's got to be applied for both cases.
>
>Yes, it should.

Agreed. Shall remove volume configuration.

>
>> We should probably cut the common parts out, as done for rt5682. Ryan,
>> can you look into this.
>
>Indeed.

OK. Shall re-use common parts and remove duplication.