[RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845
Srinivas Kandagatla
srinivas.kandagatla at linaro.org
Tue Jun 16 10:25:52 CEST 2020
On 16/06/2020 07:34, John Stultz wrote:
> CROS_EC isn't strictly required for audio to work
> on other SDM845 platforms (like the Dragonboard 845c).
>
> So lets remove the dependency and select the related
> CROS_EC options if CROS_EC is already enabled.
Sorry John, totally missed this one out!
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
> Cc: Rohit kumar <rohitkr at codeaurora.org>
> Cc: Patrick Lai <plai at codeaurora.org>
> Cc: Banajit Goswami <bgoswami at codeaurora.org>
> Cc: Liam Girdwood <lgirdwood at gmail.com>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Jaroslav Kysela <perex at perex.cz>
> Cc: Takashi Iwai <tiwai at suse.com>
> Cc: alsa-devel at alsa-project.org
> Signed-off-by: John Stultz <john.stultz at linaro.org>
> ---
> sound/soc/qcom/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index f51b28d1b94d..0434f2c7d746 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -99,12 +99,12 @@ config SND_SOC_MSM8996
>
> config SND_SOC_SDM845
> tristate "SoC Machine driver for SDM845 boards"
> - depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE
> + depends on QCOM_APR && I2C && SOUNDWIRE
> select SND_SOC_QDSP6
> select SND_SOC_QCOM_COMMON
> select SND_SOC_RT5663
> select SND_SOC_MAX98927
> - select SND_SOC_CROS_EC_CODEC
> + select SND_SOC_CROS_EC_CODEC if CROS_EC
Isn't "imply SND_SOC_CROS_EC_CODEC" better option here?
--srini
> help
> To add support for audio on Qualcomm Technologies Inc.
> SDM845 SoC-based systems.
>
More information about the Alsa-devel
mailing list