[PATCH 2/2] ASoC: rt1015: Flush DAC data before playback.

Mark Brown broonie at kernel.org
Mon Jun 15 14:17:12 CEST 2020


On Mon, Jun 15, 2020 at 11:24:33AM +0800, jack.yu at realtek.com wrote:

> +enum {
> +	Enable_Boost,
> +	Bypass_Boost,
> +};

This cleanup is nice but you should namespace the values here to ensure
they don't collide with anything.  We'd also tend to use all caps for
enum items, same as macro names.

You should probably also explicitly assign the values for the constants
to make sure it's clear how they line up with the control the user can
see, eg:

	RT1015_ENABLE_BOOST = 0,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200615/171a03c3/attachment.sig>


More information about the Alsa-devel mailing list