[PATCH] ASoC: max98390: Fix potential crash during param fw loading

[Steve Lee]

> -----Original Message-----
> From: Takashi Iwai <tiwai at suse.de>
> Sent: Wednesday, June 3, 2020 8:24 PM
> To: Steve Lee <SteveS.Lee at maximintegrated.com>
> Cc: lgirdwood at gmail.com; broonie at kernel.org; perex at perex.cz;
> tiwai at suse.com; ckeepax at opensource.cirrus.com; geert at linux-m68k.org;
> rf at opensource.wolfsonmicro.com; shumingf at realtek.com;
> srinivas.kandagatla at linaro.org; krzk at kernel.org; dmurphy at ti.com;
> jack.yu at realtek.com; nuno.sa at analog.com; linux-kernel at vger.kernel.org;
> alsa-devel at alsa-project.org; ryan.lee.maxim at gmail.com; Ryan Lee
> <RyanS.Lee at maximintegrated.com>; steves.lee.maxim at gmail.com
> Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw
> loading
> 
> EXTERNAL EMAIL
> 
> 
> 
> On Wed, 03 Jun 2020 13:18:19 +0200,
> Steve Lee wrote:
> >
> > @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component
> *component)
> >
> >       /* Dsm Setting */
> >       regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94);
> > -     regmap_write(max98390->regmap, DSMIG_EN, 0x19);
> 
> Is this change intentional?
> It wasn't mentioned in the patch description.

 It should be another change. I will re-send the patch.

> 
> 
> thanks,
> 
> Takashi