[PATCH 09/24] ASoC: soc-component: add snd_soc_component_compr_open()

Mark Brown broonie at kernel.org
Wed Jun 3 12:40:03 CEST 2020


On Tue, Jun 02, 2020 at 08:16:00AM +0900, Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

> > > component related function should be implemented at
> > > soc-component.c.
> > > This patch moves soc-compress soc_compr_components_open()
> > > to soc-component as snd_soc_component_compr_open().

> > This is change is justified in one way but it also feels like maybe
> > because the functions are so specific to compr devices, it is best to
> > leave them here. Maybe others should also chime in.

> Hmm.. I'm not sure.
> Such kind of functions are already has been changed...
> Let's ask to Maintainer.

> Mark, what do you think ?

I don't think there's one right answer here.  I guess if we have to pick
we should do the same as is being done for PCM for compressed open but
either option is fine I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200603/a1280983/attachment.sig>


More information about the Alsa-devel mailing list