[PATCH 05/24] ASoC: soc-component: add snd_soc_pcm_component_prepare()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Jun 2 01:12:10 CEST 2020
Hi Ranjani
Thank you for reviewing
> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> >
> > We have 2 type of component functions
> > snd_soc_component_xxx() is focusing to component itself,
> > snd_soc_pcm_component_xxx() is focusing to rtd related component.
> >
> > Now we can update snd_soc_component_prepare() to
> > snd_soc_pcm_component_prepare(). This patch do it.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > ---
(snip)
> > - for_each_rtd_components(rtd, i, component) {
> > - ret = snd_soc_component_prepare(component, substream);
> > - if (ret < 0) {
> > - dev_err(component->dev,
> > - "ASoC: platform prepare error: %d\n",
> > ret);
> > - goto out;
> > - }
> > + ret = snd_soc_pcm_component_prepare(substream);
> > + if (ret < 0) {
> > + dev_err(rtd->dev,
> > + "ASoC: platform prepare error: %d\n", ret);
> Morimoto-san,
> We should remove this. This will be a duplicate error message as
> snd_soc_pcm_component_prepare() would already print the error before
> returning.
Ohh, yes.
will fix in v2
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list