[PATCH 6/6] ASoC: amd: Added hw_params support for ALC1015

kernel test robot lkp at intel.com
Mon Jul 27 21:56:39 CEST 2020


Hi Ravulapati,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on next-20200727]
[cannot apply to v5.8-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ravulapati-Vishnu-vardhan-rao/ASoC-amd-Renaming-snd-soc-card-structure-and-fields/20200727-230352
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   sound/soc/amd/acp3x-rt5682-max9836.c: In function 'acp3x_1015_hw_params':
>> sound/soc/amd/acp3x-rt5682-max9836.c:140:17: error: 'struct snd_soc_pcm_runtime' has no member named 'codec_dais'
     140 |   if (strcmp(rtd->codec_dais[i]->name, "rt1015-aif"))
         |                 ^~
   sound/soc/amd/acp3x-rt5682-max9836.c:142:18: error: 'struct snd_soc_pcm_runtime' has no member named 'codec_dais'
     142 |   codec_dai = rtd->codec_dais[i];
         |                  ^~
   sound/soc/amd/acp3x-rt5682-max9836.c: At top level:
   sound/soc/amd/acp3x-rt5682-max9836.c:433:7: warning: no previous prototype for 'soc_is_rltk_max' [-Wmissing-prototypes]
     433 | void *soc_is_rltk_max(struct device *dev)
         |       ^~~~~~~~~~~~~~~

vim +140 sound/soc/amd/acp3x-rt5682-max9836.c

   128	
   129	static int acp3x_1015_hw_params(struct snd_pcm_substream *substream,
   130						struct snd_pcm_hw_params *params)
   131	{
   132		struct snd_soc_pcm_runtime *rtd = substream->private_data;
   133		struct snd_soc_dai *codec_dai;
   134		int srate, i, ret;
   135	
   136		ret = 0;
   137		srate = params_rate(params);
   138	
   139		for (i = 0; i < rtd->num_codecs; i++) {
 > 140			if (strcmp(rtd->codec_dais[i]->name, "rt1015-aif"))
   141				continue;
   142			codec_dai = rtd->codec_dais[i];
   143	
   144			ret = snd_soc_dai_set_bclk_ratio(codec_dai, 64);
   145			if (ret < 0) {
   146				dev_err(codec_dai->dev,
   147					"codec_dai bclk ratio not set\n");
   148				return ret;
   149			}
   150			ret = snd_soc_dai_set_pll(codec_dai, 0, RT1015_PLL_S_BCLK,
   151							64 * srate, 256 * srate);
   152			if (ret < 0) {
   153				dev_err(codec_dai->dev, "codec_dai PLL not set\n");
   154				return ret;
   155			}
   156			ret = snd_soc_dai_set_sysclk(codec_dai, RT1015_SCLK_S_PLL,
   157						256 * srate, SND_SOC_CLOCK_IN);
   158			if (ret < 0) {
   159				dev_err(codec_dai->dev,
   160						"codec_dai sys clock not set\n");
   161				return ret;
   162			}
   163		}
   164		return ret;
   165	}
   166	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 75087 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200728/c65abb99/attachment-0001.gz>


More information about the Alsa-devel mailing list