[PATCH] ASoC: wm8962: Do not access WM8962_GPIO_BASE

Charles Keepax ckeepax at opensource.cirrus.com
Mon Jul 27 15:27:17 CEST 2020


On Thu, Jul 23, 2020 at 04:59:24PM -0300, Fabio Estevam wrote:
> Hi Charles,
> 
> On Thu, Jul 23, 2020 at 6:21 AM Charles Keepax
> <ckeepax at opensource.cirrus.com> wrote:
> 
> > Ah ok I think I can see what is going on here, you get an EBUSY
> > if the regmap is in cache only and you try to read a register
> > which isn't in the cache. Is that what you are seeing?
> 
> After adding some debug info I got:
> 
> ************ register is 512
> wm8962 0-001a: ASoC: error at soc_component_read_no_lock on wm8962.0-001a: -16
> 
> ************ register is 515
> wm8962 0-001a: ASoC: error at soc_component_read_no_lock on wm8962.0-001a: -16
> 
> Both register 512 and 515 do not exist as per the WM8962 datasheet, so
> the driver should not try to access them, right?
> 
> This patch avoids reading from these unexisting registers, which makes
> sense IMHO.
> 
> Do you have any other suggestions to avoid these errors?

Alright fair enough, this is a good a fix as any for these two
registers. Although I would suggest considering my questions for
your additional control 4 issue, since there is a little more to
think about there.

Acked-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Thanks,
Charles


More information about the Alsa-devel mailing list