[PATCH 0/7] ASoC: qcom: Use qcom_snd_parse_of() for apq8016_sbc

Srinivas Kandagatla srinivas.kandagatla at linaro.org
Fri Jul 24 13:21:39 CEST 2020


Thanks Stephan for doing this cleanup!


On 23/07/2020 19:38, Stephan Gerhold wrote:
> At the moment we have two separate functions to parse the sound card
> properties from the device tree: qcom_snd_parse_of() for DPCM and
> apq8016_sbc_parse_of() without DPCM. These functions are almost identical
> except for a few minor differences.
> 
> This patch set extends qcom_snd_parse_of() to handle links without DPCM,
> so that we can use one common function for all (qcom) machine drivers.
> 
> Stephan Gerhold (7):
>    ASoC: qcom: Use devm for resource management
>    ASoC: qcom: common: Use snd_soc_dai_link_set_capabilities()
>    ASoC: q6afe: Remove unused q6afe_is_rx_port() function
>    ASoC: qcom: common: Support parsing links without DPCM
>    ASoC: qcom: common: Parse properties with "qcom," prefix
>    ASoC: qcom: apq8016_sbc: Use qcom_snd_parse_of()
>    ASoC: qcom: common: Avoid printing errors for -EPROBE_DEFER
> 
All the patches looks good to me,

Tested this on DragonBoard 410c!


Tested-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>

---srini

>   sound/soc/qcom/Kconfig       |   1 +
>   sound/soc/qcom/apq8016_sbc.c | 120 ++++-------------------------------
>   sound/soc/qcom/apq8096.c     |  28 +-------
>   sound/soc/qcom/common.c      |  58 ++++++++++-------
>   sound/soc/qcom/qdsp6/q6afe.c |   8 ---
>   sound/soc/qcom/qdsp6/q6afe.h |   1 -
>   sound/soc/qcom/sdm845.c      |  40 ++----------
>   7 files changed, 59 insertions(+), 197 deletions(-)
> 


More information about the Alsa-devel mailing list