[PATCH] soundwire: master: enable pm runtime
Liao, Bard
bard.liao at intel.com
Fri Jul 24 13:09:12 CEST 2020
> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Friday, July 24, 2020 4:32 PM
> To: Bard Liao <yung-chuan.liao at linux.intel.com>
> Cc: alsa-devel at alsa-project.org; vkoul at kernel.org; vinod.koul at linaro.org;
> linux-kernel at vger.kernel.org; tiwai at suse.de; broonie at kernel.org;
> jank at cadence.com; srinivas.kandagatla at linaro.org;
> rander.wang at linux.intel.com; ranjani.sridharan at linux.intel.com;
> hui.wang at canonical.com; pierre-louis.bossart at linux.intel.com; Kale, Sanyog
> R <sanyog.r.kale at intel.com>; Lin, Mengdong <mengdong.lin at intel.com>;
> Liao, Bard <bard.liao at intel.com>
> Subject: Re: [PATCH] soundwire: master: enable pm runtime
>
> On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote:
> > We should enable pm runtime.
>
> Because why?
The hierarchy of soundwire devices is platform device -> M device -> S
device. A S device is physically attached on the platform device. So the
platform device should be resumed when a S device is resumed. As the
bridge of platform device and S device, we have to implement runtime pm
on M driver. We have set runtime pm ops in M driver already, but still
need to enable runtime pm.
>
> Please read the documentation about how to write good changelog
> comments...
Sure. I will update the changelog in next version. Thanks for the advice.
>
> greg k-h
More information about the Alsa-devel
mailing list