wm8962: error at soc_component_read_no_lock

[Fabio Estevam]

On Fri, Jul 17, 2020 at 10:01 AM Fabio Estevam <festevam at gmail.com> wrote:

> If I move WM8962_ADDITIONAL_CONTROL_4 to the non-volatile region, the
> two errors related to this register are gone:
>
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -149,6 +149,7 @@ static const struct reg_default wm8962_reg[] = {
>         { 38, 0x0008 },   /* R38    - Right input PGA control */
>
>         { 40, 0x0000 },   /* R40    - SPKOUTL volume */
> +       { 48, 0x0000 },   /* R48    - Additional control(4) */
>         { 41, 0x0000 },   /* R41    - SPKOUTR volume */
>
>         { 49, 0x0010 },   /* R49    - Class D Control 1 */
> @@ -790,7 +791,6 @@ static bool wm8962_volatile_register(struct device
> *dev, unsigned int reg)
>         case WM8962_CLOCKING1:
>         case WM8962_SOFTWARE_RESET:
>         case WM8962_THERMAL_SHUTDOWN_STATUS:
> -       case WM8962_ADDITIONAL_CONTROL_4:
>         case WM8962_DC_SERVO_6:
>         case WM8962_INTERRUPT_STATUS_1:
>         case WM8962_INTERRUPT_STATUS_2:
>
> Is this a correct approach?

I have sent a patch that fixes the soc_component_read_no_lock errors
for the GPIO registers.

I can send a formal patch for fixing soc_component_read_no_lock error
WM8962_ADDITIONAL_CONTROL_4 if this proposal looks good.

Thanks