[PATCH v2] ASoC: soc-component: Add missed return for calling soc_component_ret
Shengjiu Wang
shengjiu.wang at nxp.com
Thu Jul 16 07:07:08 CEST 2020
Add missed return for calling soc_component_ret, otherwise the return
value is wrong.
Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
Signed-off-by: Shengjiu Wang <shengjiu.wang at nxp.com>
---
changes in v2
- add missed return in snd_soc_pcm_component_sync_stop and
- snd_soc_pcm_component_new
sound/soc/soc-component.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
index af9909c5492f..9565a0dd7cb6 100644
--- a/sound/soc/soc-component.c
+++ b/sound/soc/soc-component.c
@@ -647,7 +647,7 @@ int snd_soc_pcm_component_sync_stop(struct snd_pcm_substream *substream)
ret = component->driver->sync_stop(component,
substream);
if (ret < 0)
- soc_component_ret(component, ret);
+ return soc_component_ret(component, ret);
}
}
@@ -705,7 +705,7 @@ int snd_soc_pcm_component_mmap(struct snd_pcm_substream *substream,
/* FIXME. it returns 1st mmap now */
for_each_rtd_components(rtd, i, component)
if (component->driver->mmap)
- soc_component_ret(
+ return soc_component_ret(
component,
component->driver->mmap(component,
substream, vma));
@@ -723,7 +723,7 @@ int snd_soc_pcm_component_new(struct snd_soc_pcm_runtime *rtd)
if (component->driver->pcm_construct) {
ret = component->driver->pcm_construct(component, rtd);
if (ret < 0)
- soc_component_ret(component, ret);
+ return soc_component_ret(component, ret);
}
}
--
2.27.0
More information about the Alsa-devel
mailing list