[PATCH v2] ALSA: hda/realtek: enable headset mic of ASUS ROG Zephyrus G14(G401) series with ALC289

[Takashi Iwai]

On Sat, 11 Jul 2020 12:47:08 +0200,
Armas Spann wrote:
> 
> Am Samstag, den 11.07.2020, 12:20 +0200 schrieb Takashi Iwai:
> > On Sat, 11 Jul 2020 12:11:11 +0200,
> > Armas Spann wrote:
> > > Signed-off-by: Armas Spann <
> > > zappel at retarded.farm
> > > >
> > 
> > Could you give a bit more detail about what you've fixed?
> > An empty patch description is always a bad sign.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > > ---
> > >  sound/pci/hda/patch_realtek.c | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > > index 194ffa8c66ce..ff4f3eeedfd0 100644
> > > --- a/sound/pci/hda/patch_realtek.c
> > > +++ b/sound/pci/hda/patch_realtek.c
> > > @@ -6152,6 +6152,7 @@ enum {
> > >  	ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS,
> > >  	ALC269VC_FIXUP_ACER_HEADSET_MIC,
> > >  	ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE,
> > > +	ALC289_FIXUP_ASUS_G401,
> > >  };
> > >  
> > >  static const struct hda_fixup alc269_fixups[] = {
> > > @@ -7359,6 +7360,13 @@ static const struct hda_fixup alc269_fixups[] = {
> > >  		.chained = true,
> > >  		.chain_id = ALC269_FIXUP_HEADSET_MIC
> > >  	},
> > > +	[ALC289_FIXUP_ASUS_G401] = {
> > > +		.type = HDA_FIXUP_PINS,
> > > +		.v.pins = (const struct hda_pintbl[]) {
> > > +			{ 0x19, 0x03a11020 }, /* headset mic with jack detect */
> > > +			{ }
> > > +		},
> > > +	},
> > >  };
> > >  
> > >  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > > @@ -7539,6 +7547,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] =
> > > {
> > >  	SND_PCI_QUIRK(0x1043, 0x1bbd, "ASUS Z550MA",
> > > ALC255_FIXUP_ASUS_MIC_NO_PRESENCE),
> > >  	SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U",
> > > ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> > >  	SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC),
> > > +	SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14",
> > > ALC289_FIXUP_ASUS_G401),
> > >  	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE",
> > > ALC256_FIXUP_ASUS_AIO_GPIO2),
> > >  	SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
> > >  	SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC),
> > > -- 
> > > 2.27.0
> > > 
> 
> Yes, of course. 
> 
> Sorry I thought it would have be taken from the commit message when using git
> send-email.

It is.  But I guess you didn't put the texts there, only your
Signed-off-by line.

> Is it enough to have it in the conversation or must I put it into
> the patch. If it has to be inside the patch, where do I have to place the
> description? Because I think git send-mail is stripping some parts off(may be
> caused due my lack of knowledge about this)

The patch description is put in the lines before Signed-off-by.
That is, the patch would look like:
 
  From: Foo Bar <foo at bar.com>
  Subject: ALSA: hda: Fix something great

  This patch fixes blah and blah.
  More blah.

  Signed-off-by: Foo Bar <foo at bar.com>
  
  --
  .... the diff is put below ...

And when you commit "This patch fixes..." until "Signed-off-by"
lines in your own git commit as the commit log, this will be
gracefully produced by git-send-email (or git-format-patch).


Takashi