[RFC PATCH 10/23] ALSA: usb/line6: remove 'defined but not used' warning

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Jul 7 17:49:52 CEST 2020




>> -static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
>> -static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
>> +static __maybe_unused const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
>> +static __maybe_unused const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
> 
> IMO, this can be clearer to make them define.
> The static const doesn't look like a right usage in such a case in
> anyway...

Right, and the capital letters do hint at a define indeed. Will resend, 
thanks Takashi for the review.


More information about the Alsa-devel mailing list