[alsa-devel] [PATCH 10/12] ASoC: SOF: Provide probe debugfs support

[Cezary Rojewski]

On 2020-01-24 21:22, Pierre-Louis Bossart wrote:
> You should probably add a higher-level explanation in the commit message 
> that to make use of probes, the user needs to specific which buffers of 
> the firmware topology they want to extract data from, and that debugfs 
> is the configuration interface. The streaming part is handled via the 
> compressed interface.
> 
>> Define debugfs subdirectory delegated for IPC communitation with DSP.
> 
> communication.
> 

Reworded in v2, thanks.

>> Input format: uint,uint,(...) which are later translated into DWORDS
>> sequence and further into instances of struct of interest given the IPC
>> type.
> 
> we should probably add a documentation part that specifies the values 
> expected, as you did some time back.
> 

Documentation will be released on a later date as SOF's probes are still 
a very fresh subject.

>> For Extractor probes, following have been enabled:
>> - PROBE_POINT_ADD (echo <..> probe_points)
>> - PROBE_POINT_REMOVE (echo <..> probe_points_remove)
>> - PROBE_POINT_INFO (cat probe_points)
> 
> Doesn't appear very intuitive to me, is this the same as in previous 
> solutions or a new design of your own?
> 

Precisely, the usage is exactly the same. Documentation covers the 
usage, and it is actually very intuitive (as it's very simple too) once 
you get chance to put your hands on it.

>> +static ssize_t ppoints_read(struct file *file,
>> +        char __user *to, size_t count, loff_t *ppos)
> 
> avoid ppoints acronym, use probe_points_read? same in the rest of the 
> patch.
> 

Reworded in v2, thanks.