[alsa-devel] [PATCH 09/12] ASoC: SOF: Intel: Probe compress operations

[Cezary Rojewski]

On 2020-01-24 21:07, Pierre-Louis Bossart wrote:
>> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
>> index 8c2da6a2c9df..65058f5c808a 100644
>> --- a/sound/soc/sof/intel/Kconfig
>> +++ b/sound/soc/sof/intel/Kconfig
>> @@ -328,6 +328,16 @@ config SND_SOC_SOF_HDA_AUDIO_CODEC
>>         Say Y if you want to enable HDAudio codecs with SOF.
>>         If unsure select "N".
>> +config SND_SOC_SOF_HDA_PROBES
>> +    bool "SOF enable probes over HDA"
>> +    depends on SND_SOC_SOF_HDA_LINK
> 
> I think this dependency is incorrect? if we are only using the 
> controller and host-side DMAs, it's not needed at all. There is no 
> technical reason why we couldn't use probes with just I2S codecs, or 
> even in nocodec mode.
> 
> maybe you meant HDA_COMMON so that it's only used on SKL+.
> 

Addressed in v2, thanks.

>> +    depends on SND_SOC_SOF_DEBUG_PROBES
>> +    help
>> +      This option enables the data probing for Intel(R).
>> +          HDAudio platforms.
> 
> HDAudio is misleading, this could mean the HDaudio controller (but 
> that's only after SKL) or HDAudio codecs.
> 
> This should be "Intel(R) Skylake and newer platforms"?

Reworded in v2, thanks.