[alsa-devel] [PATCH] fix segfault on x32, 64-bit time_t-related format strings

[Thorsten Glaser]

On Fri, 22 Nov 2019, Takashi Iwai wrote:

> > I’ve sent them as two separate patch files attachments.
> 
> Then please make them cleanly applicable via git-am, with a proper
> subject, a proper changelog and your sign-off, etc.

I’ll resend them like that now. Sorry it took a bit, I was busy.

> At best send one patch per mail (and with a cover letter for multiple
> patches).

This is a bit tricky, as I can’t easily inject git format-patch
output into this mail setup. I will try sending them from home.

> > > Also, using time_t would be better if possible.  Unfortunately a cast
> > > is needed for printf usage, but other than that, time_t would leave us
> > > the right size.
> > 
> > In timediff() you mean? Hrm, indeed. I tried to be minimal-invasive
> > at first.
> 
> I meant using time_t as much as possible instead of long long.

I’ve done this now.

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg