[alsa-devel] [PATCH] ASoC: Intel: skl_hda_dsp_common: Fix global-out-of-bounds bug

[Wasko, Michal]

On 1/22/2020 8:52 PM, Pierre-Louis Bossart wrote:
>
>
> On 1/22/20 12:27 PM, Cezary Rojewski wrote:
>> For the last few days we have been playing with "vanilla" 5.5 kernel 
>> - one without ton of /skylake patches - to find out how could hda-dsp 
>> be enabled on skl/ kbl+ with the least amount of changes pulled from 
>> our branch possible.
>>
>> Turned out the addition of this single patch AND topology binary 
>> update got the job done.
>>
>> Now, how can we proceed with such solution. Can share the topology 
>> binary/ .conf if needed, so anyone interested can check it out.
>
> I am personally interested for tests but I doubt this option is usable 
> by anyone outside of Intel - additional issues with probe race 
> conditions with i915, e.g. on Linus' Dell XPS 9350, no DMIC support 
> and not selected anyways by Jaroslav's new logic, no UCM, and no plans 
> for the use of the HDMI common codec.

The Linux Skylake driver officially support audio over DSP on Intel cAVS 
1.5+ boards, that include Skylake HW target with hda-dsp configuration. 
The configuration is regularly tested by Intel Audio CI team.

As it was agreed with you Pierre the Skylake driver will be kept under 
maintenance and the proposed changes are about to keep hda-dsp 
configuration functional for anyone who would like to use it. Linus 
laptop issue is actually one of the good reasons why we would like to 
keep hda-dsp configuration functional

Your other statements Pierre are quite outdated:

     - Probe race conditions with i915 - resolved in HDA
     - DMIC is supported
     - UCM is not directly driver related and can be easily updated
     - Intel Audio CI was focused on common HD-A codec but the HDMI 
common codec is supported as well

> In case you didn't see it, the Skylake driver 'HDaudio codec' option 
> is suggested as one of the 'unsupported' features here:
> https://github.com/thesofproject/linux/pull/1742
>
> -Pierre

The suggestion to mark the Skylake driver 'HDaudio codec' option as 
'unsupported' is coming from you Pierre (patch from two daysago?) and I 
believe that you should consult such opinion with Intel Skylake driver 
maintainers.

Michal
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>