[alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order

[Pierre-Louis Bossart]

>>> I am not following. Is this a fix for linux-5.4-y only, or is it 
>>> needed on
>>> Mark's tree? In the latter case, what is broken? We've been using Mark's
>>> tree without issues, wondering what we missed?
>>
>> He's saying it's a fix for stable but it's just a cleanup and robustness
>> improvement in current kernels - when the patch 76d270364932 (ASoC:
>> topology: Check return value for snd_soc_add_dai_link()) was backported
>> by the bot the bot missed some other context which triggered bugs.
> 
> Exactly. It's because the commit 
> 237d19080cd37e1ccf5462e63d8577d713f6da46 ("ASoC: soc-core: remove 
> topology specific operation") removed the link->dobj checks, but this 
> commit was not picked to the stable kernels.
> 
> The initialization reordering is fine for all kernels (and makes sense), 
> so I would like to apply it everywhere.

ok, thanks for the precisions.