[alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix SKL dai count

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Jan 13 16:30:30 CET 2020



On 1/13/20 5:40 AM, Cezary Rojewski wrote:
> With fourth pin added for iDisp for skl_dai, update SOF_SKL_DAI_NUM to
> account for the change. Without this, dais from the bottom of the list
> are skipped. In current state that's the case for 'Alt Analog CPU DAI'.

Can you clarify if you are fixing an issue on TGL - which isn't 
supported in the mainline? Or fixing an issue with SKL w/ HDaudio support?

FWIW, I couldn't make HDaudio codec support work on KBL, with the 
changes in ASoC core, the HDaudio support is broken with the SKL driver 
(or depends on an unreleased topology). See traces at:

https://github.com/thesofproject/linux/pull/1667/commits/ae584cf633f232d9cf828bb599a1b620cd0b4fe0

> 
> Fixes: ac42b142cd76 ("ASoC: SOF: Intel: hda: Add iDisp4 DAI")
> Signed-off-by: Cezary Rojewski <cezary.rojewski at intel.com>
> ---
>   sound/soc/sof/intel/hda.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
> index 47408ec0de40..a4d030bfeee1 100644
> --- a/sound/soc/sof/intel/hda.h
> +++ b/sound/soc/sof/intel/hda.h
> @@ -348,7 +348,7 @@
>   
>   /* Number of DAIs */
>   #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
> -#define SOF_SKL_NUM_DAIS		14
> +#define SOF_SKL_NUM_DAIS		15
>   #else
>   #define SOF_SKL_NUM_DAIS		8
>   #endif
> 


More information about the Alsa-devel mailing list