[alsa-devel] [PATCH v2] ALSA: usb-audio: Add support for Presonus Studio 1810c

[kbuild test robot]

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on sound/for-next]
[also build test WARNING on v5.5-rc5 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/mickflemm-gmail-com/ALSA-usb-audio-Add-support-for-Presonus-Studio-1810c/20200112-014426
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-randconfig-s2-20200113 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   sound/usb/mixer_s1810c.c: In function 'snd_sc1810c_get_status_field':
>> sound/usb/mixer_s1810c.c:177:9: warning: missing braces around initializer [-Wmissing-braces]
     struct s1810c_state_packet pkt_out = { 0 };
            ^
   sound/usb/mixer_s1810c.c:177:9: warning: (near initialization for 'pkt_out.fields') [-Wmissing-braces]
   sound/usb/mixer_s1810c.c:178:9: warning: missing braces around initializer [-Wmissing-braces]
     struct s1810c_state_packet pkt_in = { 0 };
            ^
   sound/usb/mixer_s1810c.c:178:9: warning: (near initialization for 'pkt_in.fields') [-Wmissing-braces]

vim +177 sound/usb/mixer_s1810c.c

   163	
   164	/*
   165	 * When opening Universal Control the program periodicaly
   166	 * sends and receives state packets for syncinc state between
   167	 * the device and the host.
   168	 *
   169	 * Note that if we send only the request to get data back we'll
   170	 * get an error, we need to first send an empty state packet and
   171	 * then ask to receive a filled. Their seqnumbers must also match.
   172	 */
   173	static int
   174	snd_sc1810c_get_status_field(struct usb_device *dev,
   175				     u32 *field, int field_idx, uint16_t *seqnum)
   176	{
 > 177		struct s1810c_state_packet pkt_out = { 0 };
   178		struct s1810c_state_packet pkt_in = { 0 };
   179		int ret = 0;
   180	
   181		pkt_out.fields[SC1810C_STATE_F1_IDX] = SC1810C_SET_STATE_F1;
   182		pkt_out.fields[SC1810C_STATE_F2_IDX] = SC1810C_SET_STATE_F2;
   183		ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0),
   184				      SC1810C_SET_STATE_REQ,
   185				      SC1810C_SET_STATE_REQTYPE,
   186				      (*seqnum), 0, &pkt_out, sizeof(pkt_out));
   187		if (ret < 0) {
   188			dev_warn(&dev->dev, "could not send state packet (%d)\n", ret);
   189			return ret;
   190		}
   191	
   192		ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0),
   193				      SC1810C_GET_STATE_REQ,
   194				      SC1810C_GET_STATE_REQTYPE,
   195				      (*seqnum), 0, &pkt_in, sizeof(pkt_in));
   196		if (ret < 0) {
   197			dev_warn(&dev->dev, "could not get state field %u (%d)\n",
   198				 field_idx, ret);
   199			return ret;
   200		}
   201	
   202		(*field) = pkt_in.fields[field_idx];
   203		(*seqnum)++;
   204		return 0;
   205	}
   206	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 35591 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200113/6c73172c/attachment-0001.gz>