[alsa-devel] [PATCH] ALSA: hda: enable regmap internal locking

[Takashi Iwai]

On Wed, 08 Jan 2020 19:08:56 +0100,
Kai Vehmanen wrote:
> 
> This reverts commit 42ec336f1f9d ("ALSA: hda: Disable regmap
> internal locking").
> 
> Without regmap locking, there is a race between snd_hda_codec_amp_init()
> and PM callbacks issuing regcache_sync(). This was caught by
> following kernel warning trace:
> 
> <4> [358.080081] WARNING: CPU: 2 PID: 4157 at drivers/base/regmap/regcache.c:498 regcache_cache_only+0xf5/0x130
> [...]
> <4> [358.080148] Call Trace:
> <4> [358.080158]  snd_hda_codec_amp_init+0x4e/0x100 [snd_hda_codec]
> <4> [358.080169]  snd_hda_codec_amp_init_stereo+0x40/0x80 [snd_hda_codec]
> 
> Suggested-by: Takashi Iwai <tiwai at suse.de>
> BugLink: https://gitlab.freedesktop.org/drm/intel/issues/592
> Signed-off-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>

Applied now.  Thanks.


Takashi