[PATCH v2 6/8] ASoC: soc-pcm: check DAI's activity more simply

Mark Brown broonie at kernel.org
Thu Feb 27 13:37:45 CET 2020


On Thu, Feb 27, 2020 at 11:38:41AM +0900, Kuninori Morimoto wrote:
> > @@ -1225,15 +1224,10 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream)

> > +	for_each_rtd_codec_dai(rtd, i, codec_dai)
> > +		if (codec_dai->active)
> >  			snd_soc_dai_digital_mute(codec_dai, 1,
> >  						 substream->stream);

> I noticed that it calls snd_soc_dai_digital_mute(xxx, substream->stream).
> This means, it want to call mute for each Playback/Capture "last user".
> This patch was total wrong.

> Mark, [6/8] is wrong. maybe I need to reconsider [7/8].
> Can you please ignore these ?
> Please let me know if you need v3

I can drop those two, it's fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200227/12fbdf3f/attachment.sig>


More information about the Alsa-devel mailing list