[PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once"

Mark Brown broonie at kernel.org
Wed Feb 26 18:36:11 CET 2020


On Wed, Feb 26, 2020 at 09:55:47AM +0900, Kuninori Morimoto wrote:

> If each component / rtd / dai have "done" flag or count,
> soc_pcm_open() can call soc_pcm_close() directly
> without thinking about "until", because each flag can handle/indicate it.

> The good point is we can reduce duplicate implementation.
> And it can avoid future bug. Because today, we need to care both
> soc_pcm_close() and error handling in soc_pcm_open(), it is not good for me.

That goal definitely makes sense, if we can avoid problems like the ones
here it seems like a useful change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200226/32e69923/attachment.sig>


More information about the Alsa-devel mailing list