[PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai
Mark Brown
broonie at kernel.org
Wed Feb 26 13:26:19 CET 2020
On Wed, Feb 26, 2020 at 10:28:27AM +0800, jack.yu at realtek.com wrote:
> From: Jack Yu <jack.yu at realtek.com>
>
> 1. Add "static" for rt1015_aif_dai_ops.
> 2. Add "static" for rt1015_dai[].
> 3. Add operation callback for rt1015_dai[].
Please don't send multiple changes in a single patch, split them up into
separate patches - the callback certainly seems like it needs to be in a
different patch.
> @@ -664,7 +664,7 @@ static int rt1015_hw_params(struct snd_pcm_substream *substream,
> snd_soc_component_update_bits(component, RT1015_TDM_MASTER,
> RT1015_I2S_DL_MASK, val_len);
> snd_soc_component_update_bits(component, RT1015_CLK2,
> - RT1015_FS_PD_MASK, pre_div);
> + RT1015_FS_PD_MASK, pre_div << RT1015_FS_PD_SFT);
>
> return 0;
> }
This doesn't seem to be mentioned in the changelog and should probably
also be a separate patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200226/a2d760be/attachment.sig>
More information about the Alsa-devel
mailing list