[PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once"

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Feb 25 01:41:09 CET 2020


Hi Kai

Thank you for your feedback / test / review

> 1. do the cleanup locally in soc_pcm_components_open()
> 	[PATCH] ASoC: soc-pcm: fix state tracking error in snd_soc_component_open/close()
> 
> 2. revert to original implementation with "last" passed to components_open()
> 	[PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once"
> 
> 3. implement opened/module counters
> 	[PATCH][RFC] ASoC: soc-component: count snd_soc_component_open/close()
> 
> ... I have tested all three and they seem to work.
> 
> I still don't really like (1), but I agree (2) adds more code in total.
> I worry (3) might backfire with some component-substream combinations.
> 
> So maybe we'll go with (1)? We do need to merge one of them, because 
> current merged code is broken on many platforms.

It seems Mark accepted (1), and I have no big objection about it.
Thank you for your hard work

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list