[PATCH v2] ASoC: dt-bindings: renesas, rsnd: switch to yaml base Documentation
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Fri Feb 21 01:30:04 CET 2020
Hi Rob
Thank you for your feedback
> > This needs clock array. Like this
> >
> > clock-frequency = <12288000 11289600>;
>
> Sorry, but the type is already defined in the spec. You'll still get
> warnings from the common schema and you can't override that here.
>
> Not sure what to suggest. Leave it with a fixme or move to
> assigned-clocks-rates instead?
As you know, I'm not familiar with yaml base Documentation :/
I want leave it as your fixme if possible.
> > > > + # For multi OF-graph
> > > > + ports:
> > > > + description: multi OF-Graph subnode
> > > > + type: object
> > > > + patternProperties:
> > > > + "port(@.*)?":
(snip)
> > > > + $ref: "#properties/port"
> > >
> > > Would be more simple to just always have 'ports'.
> >
> > Having "ports" or "port" are case-by-case, not always.
>
> Why?
>
> This:
>
> port {};
>
> and this:
>
> ports {
> port {};
> };
>
> Are treated the same. It's perfectly valid to have 'ports' with a single port.
Yeah, if it needs only 1 port.
If I'm not misunderstanding, We are using it as
ports {
port at 0 {
endpoint {}
};
port at 1 {
endpoint {}
};
....
};
or simply
port {
endpoint {}
};
And here, sometimes, "port" and "endpoint" both need "reg".
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list