[alsa-devel] [PATCH v2 10/10] ASoC: soc.h: add for_each_pcm_streams()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Feb 17 00:59:50 CET 2020


Hi Pierre-Louis

> > ALSA SoC has SNDRV_PCM_STREAM_PLAYBACK/CAPTURE everywhere.
> > Having for_each_xxxx macro is useful.
> > This patch adds for_each_pcm_streams() for it.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > ---
> > v1 -> v2
> > 
> > 	- macro is implemented at sound/pcm.h
> > 	- care more files
> > 
> >   include/sound/pcm.h                   |  5 ++
> >   sound/soc/dwc/dwc-i2s.c               |  8 +--
> >   sound/soc/fsl/fsl_asrc_dma.c          |  4 +-
> >   sound/soc/qcom/lpass-platform.c       |  2 +-
> >   sound/soc/soc-core.c                  | 31 ++++-----
> >   sound/soc/soc-generic-dmaengine-pcm.c |  8 +--
> >   sound/soc/soc-pcm.c                   | 97 ++++++++++-----------------
> >   sound/soc/sof/sof-audio.c             | 19 ++----
> >   sound/usb/usx2y/usbusx2yaudio.c       |  9 +--
> 
> Morimoto-san, could you split this last patch in core changes and then
> one patch for each hardware?
> 
> It's not fun for people doing backports to deal with completely
> unrelated platforms. If we have one patch per hardware, then it's much
> easier to avoid conflicts and it helps minimize the number of patches
> to be maintained.

Ahh, OK.
Will do in v3

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list