[alsa-devel] [PATCH v2 05/10] ASoC: soc-pcm: remove soc_dpcm_be_digital_mute()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Fri Feb 14 03:35:46 CET 2020
From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
No one is using soc_dpcm_be_digital_mute().
If it exists only by assumption that "it may be necessary someday",
let's remove it now. Otherwise code maintenance will be difficult.
We can revive it when we really needed it.
Let's remove it, so far.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
v1 -> v2
- no change
include/sound/soc-dpcm.h | 1 -
sound/soc/soc-pcm.c | 27 ---------------------------
2 files changed, 28 deletions(-)
diff --git a/include/sound/soc-dpcm.h b/include/sound/soc-dpcm.h
index b654ebfc8766..665516387671 100644
--- a/include/sound/soc-dpcm.h
+++ b/include/sound/soc-dpcm.h
@@ -141,7 +141,6 @@ void snd_soc_dpcm_be_set_state(struct snd_soc_pcm_runtime *be, int stream,
enum snd_soc_dpcm_state state);
/* internal use only */
-int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute);
int soc_dpcm_runtime_update(struct snd_soc_card *);
#ifdef CONFIG_DEBUG_FS
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 18fbf27aad01..aafa97bbcd1d 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -2719,33 +2719,6 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
mutex_unlock(&card->mutex);
return ret;
}
-int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute)
-{
- struct snd_soc_dpcm *dpcm;
- struct snd_soc_dai *dai;
-
- for_each_dpcm_be(fe, SNDRV_PCM_STREAM_PLAYBACK, dpcm) {
-
- struct snd_soc_pcm_runtime *be = dpcm->be;
- int i;
-
- if (be->dai_link->ignore_suspend)
- continue;
-
- for_each_rtd_codec_dai(be, i, dai) {
- struct snd_soc_dai_driver *drv = dai->driver;
-
- dev_dbg(be->dev, "ASoC: BE digital mute %s\n",
- be->dai_link->name);
-
- if (drv->ops && drv->ops->digital_mute &&
- dai->playback_active)
- drv->ops->digital_mute(dai, mute);
- }
- }
-
- return 0;
-}
static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
{
--
2.17.1
More information about the Alsa-devel
mailing list